linux-kernel - Re: [alsa-devel] [PATCH][next] ASoC: Intel: bytcht_es8316: make mic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3924961d-1687-0553-09ea-6f515dee7d40@canonical.com>
Date:   Thu, 24 Jan 2019 17:29:21 +0000
From:   Colin Ian King <colin.king@...onical.com>
To:     Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Liam Girdwood <liam.r.girdwood@...ux.intel.com>,
        Jie Yang <yang.jie@...ux.intel.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Hans de Goede <hdegoede@...hat.com>,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org
Subject: Re: [alsa-devel] [PATCH][next] ASoC: Intel: bytcht_es8316: make
 mic_name static, reduces object code size

On 24/01/2019 17:27, Pierre-Louis Bossart wrote:
> 
>> diff --git a/sound/soc/intel/boards/bytcht_es8316.c
>> b/sound/soc/intel/boards/bytcht_es8316.c
>> index fa9c4cf97686..1364e4e601d8 100644
>> --- a/sound/soc/intel/boards/bytcht_es8316.c
>> +++ b/sound/soc/intel/boards/bytcht_es8316.c
>> @@ -437,7 +437,7 @@ static const struct acpi_gpio_mapping
>> byt_cht_es8316_gpios[] = {
>>     static int snd_byt_cht_es8316_mc_probe(struct platform_device *pdev)
>>   {
>> -    const char * const mic_name[] = { "in1", "in2" };
>> +    static const char * const mic_name[] = { "in1", "in2" };
>>       struct byt_cht_es8316_private *priv;
>>       struct device *dev = &pdev->dev;
>>       struct snd_soc_acpi_mach *mach;
> 
> We have the same code pattern in two other files, so if we care about
> this we should fix it across the board(s), no?
> 
> bytcht_es8316.c:    const char * const mic_name[] = { "in1", "in2" };
> bytcr_rt5640.c:    const char * const map_name[] = { "dmic1", "dmic2",
> "in1", "in3" };
> bytcr_rt5651.c:    const char * const mic_name[] = { "dmic", "in1",
> "in2", "in12" };
> 
Good point, will resend.

Colin