linux-kernel - Re: [alsa-devel] [PATCH] ASoC: soc-core: Fix null pointer dereference in soc_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190124184412.GH5641@sirena.org.uk>
Date:   Thu, 24 Jan 2019 18:44:12 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
Cc:     Curtis Malainey <cujomalainey@...gle.com>,
        rohkumar@....qualcomm.com, alsa-devel@...a-project.org,
        bgoswami@...eaurora.org, vinod.koul@...aro.org,
        linux-kernel@...r.kernel.org, plai@...eaurora.org, tiwai@...e.com,
        lgirdwood@...il.com,
        Liam Girdwood <liam.r.girdwood@...ux.intel.com>,
        Matthias Reichl <hias@...us.com>,
        Rohit kumar <rohitkr@...eaurora.org>,
        srinivas.kandagatla@...aro.org, asishb@...eaurora.org,
        Ajit Pandey <ajitp@...eaurora.org>,
        Curtis Malainey <cujomalainey@...omium.org>,
        Dylan Reid <dgreid@...gle.com>
Subject: Re: [alsa-devel] [PATCH] ASoC: soc-core: Fix null pointer
 dereference in soc_find_component

On Tue, Jan 22, 2019 at 08:01:15PM -0600, Pierre-Louis Bossart wrote:

> changes are legitimate. To move forward, maybe it's not worth spending too
> much time on a grand unification of string theory, there are simpler
> solutions: the Intel machine drivers already do get the platform driver name
> as an platform_data argument, so we could modify the dailinks platform names
> before even registering the card. I tested with the attached

Yes, that would be much better - it's vastly more idiomatic.  The
general idea is that a machine driver should know what it's expecting to
find before it starts probing.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)