linux-kernel - Re: [PATCH v4 1/2] squashfs: Add posix acl support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 25 Jan 2019 09:40:20 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Geliang Tang <geliangtang@...il.com>
Cc:     Phillip Lougher <phillip@...ashfs.org.uk>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Kees Cook <keescook@...omium.org>, Coly Li <colyli@...e.de>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/2] squashfs: Add posix acl support

On Fri, Jan 25, 2019 at 04:27:47PM +0800, Geliang Tang wrote:
> --- /dev/null
> +++ b/fs/squashfs/acl.c
> @@ -0,0 +1,69 @@
> +/*
> + * Squashfs - a compressed read only filesystem for Linux

No SPDX line?

> + *
> + * Copyright (c) 2018
> + * Phillip Lougher <phillip@...ashfs.org.uk>

Did Phillip write this file, or did you?

> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License
> + * as published by the Free Software Foundation; either version 2,
> + * or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.

No need for any of that header stuff, if you put in the proper SPDX
line.

> --- /dev/null
> +++ b/fs/squashfs/acl.h
> @@ -0,0 +1,31 @@
> +/*
> + * Squashfs - a compressed read only filesystem for Linux

<snip>

Same comments here about this file.


thanks,

greg k-h