linux-kernel - Re: [PATCH] s390: hypfs: no need to check return value of debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190125084758.GB3561@osiris>
Date:   Fri, 25 Jan 2019 09:47:58 +0100
From:   Heiko Carstens <heiko.carstens@...ibm.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org,
        Martin Schwidefsky <schwidefsky@...ibm.com>,
        linux-s390@...r.kernel.org
Subject: Re: [PATCH] s390: hypfs: no need to check return value of
 debugfs_create functions

On Tue, Jan 22, 2019 at 04:21:00PM +0100, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value.  The function can work or not, but the code logic should
> never do something different based on this.
> 
> Cc: Martin Schwidefsky <schwidefsky@...ibm.com>
> Cc: Heiko Carstens <heiko.carstens@...ibm.com>
> Cc: linux-s390@...r.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
>  arch/s390/hypfs/hypfs.h        |  6 +++---
>  arch/s390/hypfs/hypfs_dbfs.c   |  8 ++------
>  arch/s390/hypfs/hypfs_diag.c   |  9 ++++-----
>  arch/s390/hypfs/hypfs_diag0c.c |  3 ++-
>  arch/s390/hypfs/hypfs_sprp.c   |  6 +++---
>  arch/s390/hypfs/hypfs_vm.c     |  3 ++-
>  arch/s390/hypfs/inode.c        | 11 +++--------
>  7 files changed, 19 insertions(+), 27 deletions(-)

Applied, thanks!