linux-kernel - Re: [PATCH v3 -next] mtd: docg3: Fix a possible memory leak of mtd->name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 25 Jan 2019 09:40:34 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     Boris Brezillon <bbrezillon@...nel.org>
CC:     <robert.jarzmik@...e.fr>, <dwmw2@...radead.org>,
        <computersforpeace@...il.com>, <marek.vasut@...il.com>,
        <richard@....at>, <linux-kernel@...r.kernel.org>,
        <linux-mtd@...ts.infradead.org>
Subject: Re: [PATCH v3 -next] mtd: docg3: Fix a possible memory leak of
 mtd->name

On 2019/1/24 23:00, Boris Brezillon wrote:
> On Wed, 23 Jan 2019 17:28:19 +0800
> YueHaibing <yuehaibing@...wei.com> wrote:
> 
>> In case DOC_CHIPID_G3, mtd->name is not freed in err handling path,
>> which is alloced by kasprintf(). Fix this by using devm_kasprintf().
>>
>> Fixes: ae9d4934b2d7 ("mtd: docg3: add multiple floor support")
>> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
>> ---
>> v3: use devm_kasprintf
>> ---
>>  drivers/mtd/devices/docg3.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/mtd/devices/docg3.c b/drivers/mtd/devices/docg3.c
>> index 4c94fc0..59ca4f5 100644
>> --- a/drivers/mtd/devices/docg3.c
>> +++ b/drivers/mtd/devices/docg3.c
>> @@ -1767,8 +1767,8 @@ static int __init doc_set_driver_info(int chip_id, struct mtd_info *mtd)
>>  
>>  	switch (chip_id) {
>>  	case DOC_CHIPID_G3:
>> -		mtd->name = kasprintf(GFP_KERNEL, "docg3.%d",
>> -				      docg3->device_id);
>> +		mtd->name = devm_kasprintf(docg3->dev, GFP_KERNEL, "docg3.%d",
>> +					   docg3->device_id);
> 
> You forgot to remove the kfree() in the ->remove() path.

Oops..., I will fix this.

Thanks a lot!

> 
>>  		if (!mtd->name)
>>  			return -ENOMEM;
>>  		docg3->max_block = 2047;
> 
> 
> .
>