linux-kernel - Re: [PATCH 1/2] staging: erofs: use xattr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52def699-7f59-04d8-9045-6f85db11111a@huawei.com>
Date:   Fri, 25 Jan 2019 21:58:31 +0800
From:   Gao Xiang <gaoxiang25@...wei.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
CC:     Chao Yu <yuchao0@...wei.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        <devel@...verdev.osuosl.org>, <linux-erofs@...ts.ozlabs.org>,
        Chao Yu <chao@...nel.org>, LKML <linux-kernel@...r.kernel.org>,
        <weidu.du@...wei.com>, Fang Wei <fangwei1@...wei.com>,
        Miao Xie <miaoxie@...wei.com>
Subject: Re: [PATCH 1/2] staging: erofs: use xattr_prefix to wrap up

Hi Dan,

On 2019/1/25 21:26, Dan Carpenter wrote:
> On Fri, Jan 25, 2019 at 07:51:03PM +0800, Gao Xiang wrote:
>> Let's use xattr_prefix instead of open code.
>> No logic changes.
>>
>> Signed-off-by: Gao Xiang <gaoxiang25@...wei.com>
>> ---
>>  drivers/staging/erofs/xattr.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/erofs/xattr.c b/drivers/staging/erofs/xattr.c
>> index 1c9498e38f0e..eca65df46133 100644
>> --- a/drivers/staging/erofs/xattr.c
>> +++ b/drivers/staging/erofs/xattr.c
>> @@ -521,7 +521,7 @@ static int xattr_entrylist(struct xattr_iter *_it,
>>  		return 1;
>>  
>>  	/* Note that at least one of 'prefix' and 'name' should be non-NULL */
> 
> The comment is sort of confusing now.

OK, I will remove this line.

And I think I will send the whole patchset instead of this cleanup patch
only after I test the ACL feature and confirm that it works.

Sorry again about the [PATCH 2/2]...

Thanks,
Gao Xiang

> 
>> -	prefix = h->prefix != NULL ? h->prefix : h->name;
>> +	prefix = xattr_prefix(h);
>>  	prefix_len = strlen(prefix);
> 
> regards,
> dan carpenter
>