linux-kernel - Re: [PATCH v2 7/9] arm64: kdump: No need to mark crashkernel pages manually PG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190125162830.GK25901@arrakis.emea.arm.com>
Date:   Fri, 25 Jan 2019 16:28:31 +0000
From:   Catalin Marinas <catalin.marinas@....com>
To:     David Hildenbrand <david@...hat.com>
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-m68k@...ts.linux-m68k.org, linuxppc-dev@...ts.ozlabs.org,
        linux-riscv@...ts.infradead.org, linux-s390@...r.kernel.org,
        linux-mediatek@...ts.infradead.org,
        Will Deacon <will.deacon@....com>,
        James Morse <james.morse@....com>,
        Bhupesh Sharma <bhsharma@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Dave Kleikamp <dave.kleikamp@...cle.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Mike Rapoport <rppt@...ux.vnet.ibm.com>,
        Michal Hocko <mhocko@...e.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Stefan Agner <stefan@...er.ch>,
        Laura Abbott <labbott@...hat.com>,
        Greg Hackmann <ghackmann@...roid.com>,
        Johannes Weiner <hannes@...xchg.org>,
        Kristina Martsenko <kristina.martsenko@....com>,
        CHANDAN VN <chandan.vn@...sung.com>,
        AKASHI Takahiro <takahiro.akashi@...aro.org>,
        Logan Gunthorpe <logang@...tatee.com>
Subject: Re: [PATCH v2 7/9] arm64: kdump: No need to mark crashkernel pages
 manually PG_reserved

On Mon, Jan 14, 2019 at 01:59:01PM +0100, David Hildenbrand wrote:
> The crashkernel is reserved via memblock_reserve(). memblock_free_all()
> will call free_low_memory_core_early(), which will go over all reserved
> memblocks, marking the pages as PG_reserved.
> 
> So manually marking pages as PG_reserved is not necessary, they are
> already in the desired state (otherwise they would have been handed over
> to the buddy as free pages and bad things would happen).
> 
> Cc: Catalin Marinas <catalin.marinas@....com>
> Cc: Will Deacon <will.deacon@....com>
> Cc: James Morse <james.morse@....com>
> Cc: Bhupesh Sharma <bhsharma@...hat.com>
> Cc: David Hildenbrand <david@...hat.com>
> Cc: Mark Rutland <mark.rutland@....com>
> Cc: Dave Kleikamp <dave.kleikamp@...cle.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Mike Rapoport <rppt@...ux.vnet.ibm.com>
> Cc: Michal Hocko <mhocko@...e.com>
> Cc: Florian Fainelli <f.fainelli@...il.com>
> Cc: Stefan Agner <stefan@...er.ch>
> Cc: Laura Abbott <labbott@...hat.com>
> Cc: Greg Hackmann <ghackmann@...roid.com>
> Cc: Johannes Weiner <hannes@...xchg.org>
> Cc: Kristina Martsenko <kristina.martsenko@....com>
> Cc: CHANDAN VN <chandan.vn@...sung.com>
> Cc: AKASHI Takahiro <takahiro.akashi@...aro.org>
> Cc: Logan Gunthorpe <logang@...tatee.com>
> Reviewed-by: Matthias Brugger <mbrugger@...e.com>
> Signed-off-by: David Hildenbrand <david@...hat.com>

Acked-by: Catalin Marinas <catalin.marinas@....com>