linux-kernel - Re: [PATCH 1/2] regulator: mc13xxx: Use lowercase regulator names to match the DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8ba0eee6-2bfd-b1a1-8607-d57690755af1@gmail.com>
Date:   Fri, 25 Jan 2019 10:17:39 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Rob Herring <robh@...nel.org>, Mark Brown <broonie@...nel.org>
Cc:     linux-kernel@...r.kernel.org,
        Frank Rowand <frowand.list@...il.com>,
        devicetree@...r.kernel.org, Liam Girdwood <lgirdwood@...il.com>,
        Vivien Didelot <vivien.didelot@...il.com>
Subject: Re: [PATCH 1/2] regulator: mc13xxx: Use lowercase regulator names to
 match the DT

On 1/25/19 7:37 AM, Rob Herring wrote:
> Since c32569e358ad ("regulator: Use of_node_name_eq for node name
> comparisons") Vivien reported the mc13892-regulator complaining about
> not being able to find regulators.
> 
> This is because prior to that commit we used of_node_cmp() to compare
> the regulator array passed from mc13892_regulators down to
> mc13xxx_parse_regulators_dt() and they are all defined in uppercase
> letters by the MC13892_*_DEFINE* macros, whereas they are defined as
> lowercase in the DTS.
> 
> Fix this by using a lowercase regulator name to match the DT node name.
> 
> Fixes: c32569e358ad ("regulator: Use of_node_name_eq for node name comparisons")
> Reported-by: Vivien Didelot <vivien.didelot@...il.com>
> Reported-by: Florian Fainelli <f.fainelli@...il.com>
> Cc: Liam Girdwood <lgirdwood@...il.com>
> Cc: Mark Brown <broonie@...nel.org>
> Signed-off-by: Rob Herring <robh@...nel.org>

Thanks, when I looked at it last night, it seems to me that you also
need to patch the following drivers:

drivers/regulator/88pm8607.c
drivers/regulator/da9052-regulator.c
drivers/regulator/max8997-regulator.c
drivers/regulator/s5m8767.c

since they all define their array of regulators using uppercase, and
then later match that using the same logic that
drivers/regulator/mc13xxx-regulator-core.c does.
-- 
Florian