linux-kernel - Re: [PATCH ghak104 V1] audit: move loginuid and sessionid from CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHC9VhScR5xLD11n0gHTx-RFjbO9-Su+_aiL7hPMxJ+65AzN1Q@mail.gmail.com>
Date:   Fri, 25 Jan 2019 13:27:08 -0500
From:   Paul Moore <paul@...l-moore.com>
To:     Richard Guy Briggs <rgb@...hat.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Linux-Audit Mailing List <linux-audit@...hat.com>,
        Eric Paris <eparis@...hat.com>, Steve Grubb <sgrubb@...hat.com>
Subject: Re: [PATCH ghak104 V1] audit: move loginuid and sessionid from
 CONFIG_ AUDITSYSCALL to AUDIT

On Tue, Jan 22, 2019 at 5:07 PM Richard Guy Briggs <rgb@...hat.com> wrote:
> loginuid and sessionid (and audit_log_session_info) should be part of
> CONFIG_AUDIT scope and not CONFIG_AUDITSYSCALL since it is used in
> CONFIG_CHANGE, ANOM_LINK, FEATURE_CHANGE (and INTEGRITY_RULE), none of
> which are otherwise dependent on AUDITSYSCALL.
>
> Please see github issue
> https://github.com/linux-audit/audit-kernel/issues/104
>
> Signed-off-by: Richard Guy Briggs <rgb@...hat.com>
> ---
>  fs/proc/base.c        |  6 ++--
>  include/linux/audit.h | 42 +++++++++++++------------
>  include/linux/sched.h |  2 +-
>  init/init_task.c      |  2 +-
>  kernel/audit.c        | 85 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  kernel/auditsc.c      | 84 --------------------------------------------------
>  6 files changed, 113 insertions(+), 108 deletions(-)

Looks good, merged.

-- 
paul moore
www.paul-moore.com