linux-kernel - Re: [PATCH] KVM: x86: Mark expected switch fall-throughs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6ac2ac84-0632-2489-eb13-21323a6b4be4@redhat.com>
Date:   Fri, 25 Jan 2019 19:31:21 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Radim Krčmář <rkrcmar@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        Joerg Roedel <joro@...tes.org>
Cc:     kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH] KVM: x86: Mark expected switch fall-throughs

On 25/01/19 19:23, Gustavo A. R. Silva wrote:
> diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
> index f6915f10e584..1de38062026e 100644
> --- a/arch/x86/kvm/vmx/vmx.c
> +++ b/arch/x86/kvm/vmx/vmx.c
> @@ -1773,7 +1773,7 @@ static int vmx_get_msr(struct kvm_vcpu *vcpu, struct msr_data *msr_info)
>  		if (!msr_info->host_initiated &&
>  		    !guest_cpuid_has(vcpu, X86_FEATURE_RDTSCP))
>  			return 1;
> -		/* Otherwise falls through */
> +		/* Else, falls through */
>  	default:
>  		msr = find_msr_entry(vmx, msr_info->index);
>  		if (msr) {

I would say this is a compiler QoI issue and in general there were other
cases like this one where the comments in the KVM source are reasonable,
but I guess it's okay.  Patch queued.

Paolo