linux-kernel - Re: [PATCH] lib/cmdline.c: mark expected switch fall-throughs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <14d9d30d-3c33-34a6-5401-016ff60b35c1@embeddedor.com>
Date:   Fri, 25 Jan 2019 18:56:11 -0600
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Kees Cook <keescook@...omium.org>
Cc:     LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] lib/cmdline.c: mark expected switch fall-throughs



On 1/25/19 6:18 PM, Kees Cook wrote:
> On Sat, Jan 26, 2019 at 9:31 AM Gustavo A. R. Silva
> <gustavo@...eddedor.com> wrote:
>>
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warnings:
>>
>> lib/cmdline.c:137:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> lib/cmdline.c:140:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> lib/cmdline.c:143:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> lib/cmdline.c:146:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> lib/cmdline.c:149:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> 
> Acked-by: Kees Cook <keescook@...omium.org>
> 

Now applied to for-next/kspp, thanks.

https://git.kernel.org/gustavoars/c/5dd481673c3ddd27d36851754bafbaa82bdff34f

Cheers!
--
Gustavo