linux-kernel - Re: [PATCH 1/5 v9] regulator: gpio: Convert to use descriptors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdauCup4U+vRcMj5JFiNCzMvBMoaAqg_ot7ZbHCDQU6V4g@mail.gmail.com>
Date:   Sat, 26 Jan 2019 13:22:56 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Mark Brown <broonie@...nel.org>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Charles Keepax <ckeepax@...nsource.cirrus.com>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Petr Cvek <petr.cvek@....cz>,
        Robert Jarzmik <robert.jarzmik@...e.fr>,
        Paul Parsons <lost.distance@...oo.com>,
        Kevin Hilman <khilman@...libre.com>,
        Neil Armstrong <narmstrong@...libre.com>
Subject: Re: [PATCH 1/5 v9] regulator: gpio: Convert to use descriptors

On Thu, Jan 24, 2019 at 6:50 PM Mark Brown <broonie@...nel.org> wrote:
> On Mon, Jan 21, 2019 at 10:12:02AM +0100, Linus Walleij wrote:
> > This converts the GPIO regulator driver to use decriptors only.
>
> This patch breaks the build for me:
>
> drivers/regulator/gpio-regulator.c: In function ‘gpio_regulator_probe’:
> drivers/regulator/gpio-regulator.c:256:33: error: ‘dev’ undeclared (first use in this function); did you mean ‘pdev’?
>   drvdata->gpiods = devm_kzalloc(dev, sizeof(struct gpio_desc *),

Hm that's fishy, I have compiled and boot tested so it must be that
this is somehow the wrong patch contents or I didn't properly
merge back some changes :/

OK I get back to double- and triplecheck the build on each patch.

Sorry for the mess.

Yours,
Linus Walleij