[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CANZrA2YcgKq3N5LM6__djG1it3D1ATjHeaTMtoeZD3KLhHVZMg@mail.gmail.com>
Date: Sat, 26 Jan 2019 17:18:22 +0100
From: Florian La Roche <florian.laroche@...glemail.com>
To: linux-kernel@...r.kernel.org
Cc: Crt Mori <cmo@...exis.com>, Joe Perches <joe@...ches.com>,
Davidlohr Bueso <dave@...olabs.net>,
Will Deacon <will.deacon@....com>,
Peter Zijlstra <peterz@...radead.org>,
Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: int_sqrt() adjustments
Hello all,
The first part of this patch is wrong: it changes from an unsigned long
param to __fls() to an unsigned int param in fls(). One option would be
to add another implementation of flsl() or given the minimalistic usage
of int_sqrt() in the kernel to keep the current code with __fls() and only
change masking the lowest bit.
The only other nitpick I have come up with: Adding __attribute_const__
could be possible.
best regards,
Florian La Roche
Powered by blists - more mailing lists