linux-kernel - Re: [PATCH] staging:iio:ad7152: Rename misspelled RESEVERD -> RESERVED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 26 Jan 2019 18:13:21 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Rodrigo Ribeiro <rodrigorsdc@...il.com>
Cc:     Alexandru Ardelean <ardeleanalex@...il.com>, lars@...afoo.de,
        Michael.Hennerich@...log.com, knaack.h@....de,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        gregkh@...uxfoundation.org, linux-iio@...r.kernel.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        kernel-usp@...glegroups.com, Rafael Tsuha <rafael.tsuha@....br>
Subject: Re: [PATCH] staging:iio:ad7152: Rename misspelled RESEVERD ->
 RESERVED

On Fri, 25 Jan 2019 22:14:32 -0200
Rodrigo Ribeiro <rodrigorsdc@...il.com> wrote:

> Em sex, 25 de jan de 2019 às 21:46, Rodrigo Ribeiro
> <rodrigorsdc@...il.com> escreveu:
> >
> > Em sex, 25 de jan de 2019 às 06:20, Alexandru Ardelean
> > <ardeleanalex@...il.com> escreveu:  
> > >
> > > On Thu, Jan 24, 2019 at 9:35 PM Rodrigo Ribeiro <rodrigorsdc@...il.com> wrote:  
> > > >
> > > > Remove the checkpatch.pl check:
> > > >
> > > > CHECK: 'RESEVERD' may be misspelled - perhaps 'RESERVED'?  
> > >
> > > Hey,  
> >
> > Hi,
> >
> > Thanks for answering.
> >  
> > > A bit curios about this one.
> > > Are you using this chip/driver ?  
> >
> > No, I am just a student at USP (University of São Paulo) starting in Linux
> > Kernel and a new member of the USP Linux Kernel group that has contributed
> > for a few months.
> >  
> > > Thing is: the part is nearing EOL, and it could be an idea to be
> > > marked for removal (since it's still in staging).
> > > But if there are users for this driver, it could be left around for a while.  
> >
> > This is my first patch in Linux Kernel, but if the driver will be removed, I
> > can send a patch for another driver. Is there any driver that I can
> > fix a style warning?  
> 
> Maybe, one checkstyle patch is enough, right? Which drivers can I truly
> contribute to?

How about the ad7150?  That one is still listed as production.
What do you think Alex, you probably have better visibility on the
status of these parts and their drivers than I do!

(note I haven't even opened that one for a few years so no idea
what state the driver is in!)

Jonathan

> 
> > Thanks
> >
> >
> > Em sex, 25 de jan de 2019 às 06:20, Alexandru Ardelean
> > <ardeleanalex@...il.com> escreveu:  
> > >
> > > On Thu, Jan 24, 2019 at 9:35 PM Rodrigo Ribeiro <rodrigorsdc@...il.com> wrote:  
> > > >
> > > > Remove the checkpatch.pl check:
> > > >
> > > > CHECK: 'RESEVERD' may be misspelled - perhaps 'RESERVED'?  
> > >
> > > Hey,
> > >
> > > A bit curios about this one.
> > > Are you using this chip/driver ?
> > >
> > > Thing is: the part is nearing EOL, and it could be an idea to be
> > > marked for removal (since it's still in staging).
> > > But if there are users for this driver, it could be left around for a while.
> > >
> > > Thanks
> > > Alex
> > >  
> > > >
> > > > Signed-off-by: Rodrigo Ribeiro <rodrigorsdc@...il.com>
> > > > Signed-off-by: Rafael Tsuha <rafael.tsuha@....br>
> > > > ---
> > > > This macro is not used anywhere. Should we just correct the
> > > > spelling or remove the macro?
> > > >
> > > >  drivers/staging/iio/cdc/ad7152.c | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/staging/iio/cdc/ad7152.c b/drivers/staging/iio/cdc/ad7152.c
> > > > index 25f51db..c9da6d4 100644
> > > > --- a/drivers/staging/iio/cdc/ad7152.c
> > > > +++ b/drivers/staging/iio/cdc/ad7152.c
> > > > @@ -35,7 +35,7 @@
> > > >  #define AD7152_REG_CH2_GAIN_HIGH       12
> > > >  #define AD7152_REG_CH2_SETUP           14
> > > >  #define AD7152_REG_CFG                 15
> > > > -#define AD7152_REG_RESEVERD            16
> > > > +#define AD7152_REG_RESERVED            16
> > > >  #define AD7152_REG_CAPDAC_POS          17
> > > >  #define AD7152_REG_CAPDAC_NEG          18
> > > >  #define AD7152_REG_CFG2                        26
> > > > --
> > > > 2.7.4
> > > >