linux-kernel - Re: [PATCH v3 2/2] staging: erofs: complete POSIX ACL support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6240fd8c-f575-5fb7-6a4c-7d6f59063527@huawei.com>
Date:   Sat, 26 Jan 2019 14:43:15 +0800
From:   Chao Yu <yuchao0@...wei.com>
To:     Gao Xiang <hsiangkao@....com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     <devel@...verdev.osuosl.org>, <linux-erofs@...ts.ozlabs.org>,
        LKML <linux-kernel@...r.kernel.org>, <chao@...nel.org>,
        <weidu.du@...wei.com>, Miao Xie <miaoxie@...wei.com>,
        Gao Xiang <gaoxiang25@...wei.com>
Subject: Re: [PATCH v3 2/2] staging: erofs: complete POSIX ACL support

On 2019/1/26 11:48, Gao Xiang wrote:
> From: Gao Xiang <gaoxiang25@...wei.com>
> 
> Let's add .get_acl() to read the file's acl from its xattrs
> to make POSIX ACL usable.
> 
> Here is the on-disk detail,
> fullname: system.posix_acl_access
> struct erofs_xattr_entry:
>         .e_name_len = 0
>         .e_name_index = EROFS_XATTR_INDEX_POSIX_ACL_ACCESS (2)
> 
> fullname: system.posix_acl_default
> struct erofs_xattr_entry:
> 	.e_name_len = 0
> 	.e_name_index = EROFS_XATTR_INDEX_POSIX_ACL_DEFAULT (3)
> 
> Signed-off-by: Gao Xiang <gaoxiang25@...wei.com>
> ---
> change log v3:
>  - kvmalloc -> erofs_kmalloc suggested by Chao;
>  - update SB_POSIXACL for the remount case as well;

Oh, correct, remount case, I missed that one.

It looks good to me now. :)

Reviewed-by: Chao Yu <yuchao0@...wei.com>

Thanks,