linux-kernel - Re: [PATCH 1/2] PCI: hv: Replace hv_vp_set with hv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190126003239.GB1837@m-hyperV>
Date:   Fri, 25 Jan 2019 16:32:40 -0800
From:   Maya Nakamura <m.maya.nakamura@...il.com>
To:     Vitaly Kuznetsov <vkuznets@...hat.com>
Cc:     linux-kernel@...r.kernel.org,
        driverdev-devel@...uxdriverproject.org, haiyangz@...rosoft.com,
        marcelo.cerri@...onical.com, lorenzo.pieralisi@....com,
        bhelgaas@...gle.com, linux-pci@...r.kernel.org, kys@...rosoft.com,
        sthemmin@...rosoft.com, olaf@...fle.de, apw@...onical.com,
        jasowang@...hat.com, mikelley@...rosoft.com,
        Alexander.Levin@...rosoft.com
Subject: Re: [PATCH 1/2] PCI: hv: Replace hv_vp_set with hv_vpset

On Thu, Jan 24, 2019 at 02:12:13PM +0100, Vitaly Kuznetsov wrote:
> Maya Nakamura <m.maya.nakamura@...il.com> writes:
> 
> > @@ -460,12 +454,16 @@ struct hv_pcibus_device {
> >  	struct msi_controller msi_chip;
> >  	struct irq_domain *irq_domain;
> >  
> > -	/* hypercall arg, must not cross page boundary */
> > -	struct retarget_msi_interrupt retarget_msi_interrupt_params;
> > -
> >  	spinlock_t retarget_msi_interrupt_lock;
> >  
> >  	struct workqueue_struct *wq;
> > +
> > +	/* hypercall arg, must not cross page boundary */
> > +	struct retarget_msi_interrupt retarget_msi_interrupt_params;
> > +
> > +	/*
> > +	 * Don't put anything here: retarget_msi_interrupt_params must be last
> > +	 */
> 
> This change seems to be unrelated and not anyhow described in the commit
> message - or did I miss something?
> 
Thank you for pointing that out. I will add why it was moved in v2.

Maya
> 
> -- 
> Vitaly