[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190127210532.GE21149@hacktheplanet>
Date: Sun, 27 Jan 2019 16:05:32 -0500
From: Scott Bauer <sbauer@...donthack.me>
To: David Kozub <zub@...ux.fjfi.cvut.cz>
Cc: Jens Axboe <axboe@...nel.dk>,
Jonathan Derrick <jonathan.derrick@...el.com>,
linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
Jonas Rabenstein <jonas.rabenstein@...dium.uni-erlangen.de>
Subject: Re: [PATCH v3 05/16] block: sed-opal: unify cmd start
On Tue, Jan 22, 2019 at 11:31:36PM +0100, David Kozub wrote:
> Every step starts with resetting the cmd buffer as well as the comid and
> constructs the appropriate OPAL_CALL command. Consequently, those
> actions may be combined into one generic function. On should take care
> that the opening and closing tokens for the argument list are already
> emitted by cmd_start and cmd_finalize respectively and thus must not be
> additionally added.
>
> Co-authored-by: Jonas Rabenstein <jonas.rabenstein@...dium.uni-erlangen.de>
> Signed-off-by: David Kozub <zub@...ux.fjfi.cvut.cz>
> Signed-off-by: Jonas Rabenstein <jonas.rabenstein@...dium.uni-erlangen.de>
Reviewed-by: Scott Bauer <sbauer@...donthack.me>
Powered by blists - more mailing lists