linux-kernel - [PATCH] tty: increase the default flip buffer limit to 2*640K

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190128163843.688-1-martink@posteo.de>
Date:   Mon, 28 Jan 2019 17:38:43 +0100
From:   Martin Kepplinger <martink@...teo.de>
To:     gregkh@...uxfoundation.org, jslaby@...e.com
Cc:     linux-kernel@...r.kernel.org,
        Manfred Schlaegl <manfred.schlaegl@...zinger.com>,
        Martin Kepplinger <martin.kepplinger@...zinger.com>
Subject: [PATCH] tty: increase the default flip buffer limit to 2*640K

From: Manfred Schlaegl <manfred.schlaegl@...zinger.com>

The default value for this was 64K. We increase this by a factor of
10 to 640K to prevent data loss when using fast serial interfaces.

Since this value is only a maximum limit for allocation and isn't used
by default, this change has minimal effect on systems with slow interfaces.

Signed-off-by: Manfred Schlaegl <manfred.schlaegl@...zinger.com>
Signed-off-by: Martin Kepplinger <martin.kepplinger@...zinger.com>
---

Is there any reason for this _limit_ to be as small as 64K?

thanks,

                          martin



 drivers/tty/tty_buffer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/tty_buffer.c b/drivers/tty/tty_buffer.c
index 77070c2d1240..ec145a59f199 100644
--- a/drivers/tty/tty_buffer.c
+++ b/drivers/tty/tty_buffer.c
@@ -26,7 +26,7 @@
  * Byte threshold to limit memory consumption for flip buffers.
  * The actual memory limit is > 2x this amount.
  */
-#define TTYB_DEFAULT_MEM_LIMIT	65536
+#define TTYB_DEFAULT_MEM_LIMIT	(640 * 1024UL)
 
 /*
  * We default to dicing tty buffer allocations to this many characters
-- 
2.20.1