linux-kernel - Re: linux-next: build warning after merge of the btrfs-kdave tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 28 Jan 2019 17:53:42 +0100
From:   David Sterba <dsterba@...e.cz>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Qu Wenruo <wqu@...e.com>
Subject: Re: linux-next: build warning after merge of the btrfs-kdave tree

On Thu, Jan 24, 2019 at 09:53:38AM +1100, Stephen Rothwell wrote:
> Hi David,
> 
> After merging the btrfs-kdave tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> fs/btrfs/relocation.c: In function 'insert_dirty_subv':
> fs/btrfs/relocation.c:2138:6: warning: unused variable 'root_objectid' [-Wunused-variable]
>   u64 root_objectid = root->root_key.objectid;
>       ^~~~~~~~~~~~~
> 
> Introduced by commit
> 
>   7b837199c581 ("btrfs: relocation: Delay reloc tree deletion after merge_reloc_roots()")
> 
> Presumably the ASSERT is compiled out in this configuration.

Agreed, thanks for the report. I'll drop the temporary variable.