[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190128155849.GB26200@ulmo>
Date: Mon, 28 Jan 2019 16:58:49 +0100
From: Thierry Reding <thierry.reding@...il.com>
To: Heiko Stuebner <heiko@...ech.de>
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
seanpaul@...omium.org, briannorris@...omium.org, hl@...k-chips.com,
nickey.yang@...k-chips.com, p.zabel@...gutronix.de
Subject: Re: [PATCH v4 RESEND] drm/panel: add Kingdisplay kd097d04 panel
driver
On Tue, Oct 30, 2018 at 10:15:28AM +0100, Heiko Stuebner wrote:
> From: Nickey Yang <nickey.yang@...k-chips.com>
>
> Support Kingdisplay kd097d04 9.7" 1536x2048 TFT LCD panel,
> it is a MIPI dual-DSI panel.
>
> v4-resend:
> - Thierry noted missing dt-bindings for v4 but forgot that he
> already had applied them one kernel release back in
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ebc950fdff6d5f9250cd5a5a348af97f7d8508df
> v4:
> - address Philipp's comments
> - real range for usleep_range and
> - poweroff ordering in kingdisplay_panel_prepare
> - return value beautification in panel_probe
> - update author naming for full name
> v3:
> - address Thierry's comments
> - error handling for init dsi writes in init
> - unconditionally remove the panel
> - don't use drm_panel_detach
> - a bit of variable signednes wiggling
> - I did talk to ChromeOS people and the delays really should be as short
> as possible, so dropped the 100ms from the delay comments
> v2:
> - update timing + cmds from chromeos kernel
> - new backlight API including switch to devm_of_find_backlight
> - fix most of Sean Paul's comments
> enable/prepare tracking seems something all panels do
> - document origins of the init sequence
> - lanes per dsi interface to 4 (two interfaces). Matches how tegra
> and pending rockchip dual-dsi handle (dual-)dsi lanes
> - spdx header instead of license boilerplate
>
> Signed-off-by: Nickey Yang <nickey.yang@...k-chips.com>
> Signed-off-by: Heiko Stuebner <heiko@...ech.de>
> ---
> drivers/gpu/drm/panel/Kconfig | 11 +
> drivers/gpu/drm/panel/Makefile | 1 +
> .../drm/panel/panel-kingdisplay-kd097d04.c | 473 ++++++++++++++++++
> 3 files changed, 485 insertions(+)
> create mode 100644 drivers/gpu/drm/panel/panel-kingdisplay-kd097d04.c
Applied to drm-misc-next, thanks.
Thierry
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists