linux-kernel - Re: [PATCH 0/2] mm, memory_hotplug: fix uninitialized pages fallouts.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190128184528.GU18811@dhcp22.suse.cz>
Date:   Mon, 28 Jan 2019 19:45:28 +0100
From:   Michal Hocko <mhocko@...nel.org>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     Mikhail Zaslonko <zaslonko@...ux.ibm.com>,
        Mikhail Gavrilov <mikhail.v.gavrilov@...il.com>,
        Pavel Tatashin <pasha.tatashin@...een.com>,
        schwidefsky@...ibm.com, heiko.carstens@...ibm.com,
        gerald.schaefer@...ibm.com, linux-mm@...ck.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/2] mm, memory_hotplug: fix uninitialized pages fallouts.

On Mon 28-01-19 19:41:39, Michal Hocko wrote:
> On Mon 28-01-19 09:50:54, Andrew Morton wrote:
> > On Mon, 28 Jan 2019 15:45:04 +0100 Michal Hocko <mhocko@...nel.org> wrote:
> > 
> > > Mikhail has posted fixes for the two bugs quite some time ago [1]. I
> > > have pushed back on those fixes because I believed that it is much
> > > better to plug the problem at the initialization time rather than play
> > > whack-a-mole all over the hotplug code and find all the places which
> > > expect the full memory section to be initialized. We have ended up with
> > > 2830bf6f05fb ("mm, memory_hotplug: initialize struct pages for the full
> > > memory section") merged and cause a regression [2][3]. The reason is
> > > that there might be memory layouts when two NUMA nodes share the same
> > > memory section so the merged fix is simply incorrect.
> > > 
> > > In order to plug this hole we really have to be zone range aware in
> > > those handlers. I have split up the original patch into two. One is
> > > unchanged (patch 2) and I took a different approach for `removable'
> > > crash. It would be great if Mikhail could test it still works for his
> > > memory layout.
> > > 
> > > [1] http://lkml.kernel.org/r/20181105150401.97287-2-zaslonko@linux.ibm.com
> > > [2] https://bugzilla.redhat.com/show_bug.cgi?id=1666948
> > > [3] http://lkml.kernel.org/r/20190125163938.GA20411@dhcp22.suse.cz
> > 
> > Any thoughts on which kernel version(s) need these patches?
> 
> My remark in 2830bf6f05fb still holds
>     : This has alwways been problem AFAIU.  It just went unnoticed because we
>     : have zeroed memmaps during allocation before f7f99100d8d9 ("mm: stop
>     : zeroing memory during allocation in vmemmap") and so the above test
>     : would simply skip these ranges as belonging to zone 0 or provided a
>     : garbage.
>     :
>     : So I guess we do care for post f7f99100d8d9 kernels mostly and
>     : therefore Fixes: f7f99100d8d9 ("mm: stop zeroing memory during
>     : allocation in vmemmap")
> 
> But, please let's wait for the patch 1 to be confirmed to fix the issue.

Also the revert [1] should be applied first. I thought Linus would pick
it up but he hasn't done so yet.

[1] http://lkml.kernel.org/r/20190125181549.GE20411@dhcp22.suse.cz
-- 
Michal Hocko
SUSE Labs