linux-kernel - Re: [PATCH v2 01/12] platform/chrome: cromeos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 28 Jan 2019 11:28:02 -0800
From:   Guenter Roeck <groeck@...gle.com>
To:     Enric Balletbo i Serra <enric.balletbo@...labora.com>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        Guenter Roeck <groeck@...omium.org>,
        Gwendal Grignou <gwendal@...omium.org>, kernel@...labora.com,
        Benson Leung <bleung@...omium.org>,
        Colin Cross <ccross@...roid.com>,
        Tony Luck <tony.luck@...el.com>,
        Anton Vorontsov <anton@...msg.org>,
        Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH v2 01/12] platform/chrome: cromeos_pstore: switch to SPDX identifier

On Sat, Jan 26, 2019 at 1:51 AM Enric Balletbo i Serra
<enric.balletbo@...labora.com> wrote:
>
> Adopt the SPDX license identifier headers to ease license compliance
> management. Also fix the module license mismatch and change the term
> 'Chrome OS' for 'ChromeOS' to be coherent with other drivers.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>

Reviewed-by: Guenter Roeck <groeck@...omium.org>

> ---
>
> Changes in v2:
> - Removed the patches that removed the unnused includes (were wrong).
> - Add patches for all files in platform/chrome that didn't switch yet.
>
>  drivers/platform/chrome/chromeos_pstore.c | 17 ++++++-----------
>  1 file changed, 6 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/platform/chrome/chromeos_pstore.c b/drivers/platform/chrome/chromeos_pstore.c
> index b0693fdec8c6..d13770785fb5 100644
> --- a/drivers/platform/chrome/chromeos_pstore.c
> +++ b/drivers/platform/chrome/chromeos_pstore.c
> @@ -1,12 +1,7 @@
> -/*
> - *  chromeos_pstore.c - Driver to instantiate Chromebook ramoops device
> - *
> - *  Copyright (C) 2013 Google, Inc.
> - *
> - *  This program is free software; you can redistribute it and/or modify
> - *  it under the terms of the GNU General Public License as published by
> - *  the Free Software Foundation, version 2 of the License.
> - */
> +// SPDX-License-Identifier: GPL-2.0
> +// Driver to instantiate Chromebook ramoops device.
> +//
> +// Copyright (C) 2013 Google, Inc.
>
>  #include <linux/acpi.h>
>  #include <linux/dmi.h>
> @@ -138,5 +133,5 @@ static void __exit chromeos_pstore_exit(void)
>  module_init(chromeos_pstore_init);
>  module_exit(chromeos_pstore_exit);
>
> -MODULE_DESCRIPTION("Chrome OS pstore module");
> -MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("ChromeOS pstore module");
> +MODULE_LICENSE("GPL v2");
> --
> 2.20.1
>