linux-kernel - Re: [PATCH v2 06/12] platform/chrome: cros_ec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABXOdTef3AUEp+tb1pJQuid=C20p+n_F5MuTxGtRYp=V79-mNQ@mail.gmail.com>
Date:   Mon, 28 Jan 2019 11:31:49 -0800
From:   Guenter Roeck <groeck@...gle.com>
To:     Enric Balletbo i Serra <enric.balletbo@...labora.com>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        Guenter Roeck <groeck@...omium.org>,
        Gwendal Grignou <gwendal@...omium.org>, kernel@...labora.com,
        Benson Leung <bleung@...omium.org>
Subject: Re: [PATCH v2 06/12] platform/chrome: cros_ec_i2c: switch to SPDX identifier

On Sat, Jan 26, 2019 at 1:51 AM Enric Balletbo i Serra
<enric.balletbo@...labora.com> wrote:
>
> Adopt the SPDX license identifier headers to ease license compliance
> management. Also fix the module license mismatch and change the
> description for a more descriptive phrase.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> ---
>
> Changes in v2: None
>
>  drivers/platform/chrome/cros_ec_i2c.c | 22 ++++++----------------
>  1 file changed, 6 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_i2c.c b/drivers/platform/chrome/cros_ec_i2c.c
> index 739b985c97e1..691744912dac 100644
> --- a/drivers/platform/chrome/cros_ec_i2c.c
> +++ b/drivers/platform/chrome/cros_ec_i2c.c
> @@ -1,17 +1,7 @@
> -/*
> - * ChromeOS EC multi-function device (I2C)
> - *
> - * Copyright (C) 2012 Google, Inc
> - *
> - * This software is licensed under the terms of the GNU General Public
> - * License version 2, as published by the Free Software Foundation, and
> - * may be copied, distributed, and modified under those terms.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> - * GNU General Public License for more details.
> - */
> +// SPDX-License-Identifier: GPL-2.0+

Should be GPL 2.0 only.

> +// I2C interface for ChromeOS Embedded Controller
> +//
> +// Copyright (C) 2012 Google, Inc
>
>  #include <linux/acpi.h>
>  #include <linux/delay.h>
> @@ -373,5 +363,5 @@ static struct i2c_driver cros_ec_driver = {
>
>  module_i2c_driver(cros_ec_driver);
>
> -MODULE_LICENSE("GPL");
> -MODULE_DESCRIPTION("ChromeOS EC multi function device");
> +MODULE_LICENSE("GPL v2");
> +MODULE_DESCRIPTION("I2C interface for ChromeOS Embedded Controller");
> --
> 2.20.1
>