linux-kernel - Re: Add Ingenic X1000 RTC support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1548708484.7511.3@crapouillou.net>
Date:   Mon, 28 Jan 2019 17:48:04 -0300
From:   Paul Cercueil <paul@...pouillou.net>
To:     Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc:     Zhou Yanjie <zhouyanjie@...o.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-rtc@...r.kernel.org, devicetree@...r.kernel.org,
        a.zummo@...ertech.it, robh+dt@...nel.org, paul.burton@...s.com,
        mark.rutland@....com, syq@...ian.org, jiaxun.yang@...goat.com,
        772753199@...com
Subject: Re: Add Ingenic X1000 RTC support.

Hi,

> Hello,
> 
> This seems like a useless renaming to me, can you elaborate a bit 
> more?
> 
> I'd also like to have Paul and Lars-Peter comment.

According to the patchset, the RTC in the X1000 does not behave any 
different
than the one in the JZ4780 SoC. Therefore patches 1/2 should be dropped.
In your devicetree bindings, just use the "ingenic,jz4780-rtc" 
compatible
string instead. The same goes for all the drivers (e.g. the uart one).

I don't really mind the renaming, maybe replace "Ingenic JZ47xx SoCs" 
with
just "Ingenic SoCs" since XBurst is just the name of the CPU inside 
these
SoCs.

Regards,
-Paul