linux-kernel - Re: [PATCH] extcon: Fix build issues in ptn5150

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3fd82d2a-c3db-0afa-13bb-25206aeb9ccd@infradead.org>
Date:   Mon, 28 Jan 2019 13:26:42 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Vijai Kumar K <vijaikumar.kanagarajan@...il.com>,
        sfr@...b.auug.org.au, linux-next@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        MyungJoo Ham <myungjoo.ham@...sung.com>,
        Chanwoo Choi <cw00.choi@...sung.com>
Subject: Re: [PATCH] extcon: Fix build issues in ptn5150

On 1/27/19 11:10 PM, Vijai Kumar K wrote:
> On Mon, Jan 28, 2019 at 10:08:12AM +0530, Vijai Kumar K wrote:
> I was wondering, what is the normal procedure in the below case
> when the build fails because of the driver.
> Should I send a new patch as a whole [PATCH v3] for the driver
> or should I send a new patch to fix the issue like below.

Hi,

I think that's up to the maintainer who merged the version that is
currently in linux-next.

For the patch:
Acked-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> Thanks,
> Vijai Kumar K
>> - extcon-ptn5150 driver uses gpio libraries
>> - Add GPIOLIB in depends section of Kconfig
>>
>> Error:
>> -----
>>>   CC      drivers/extcon/extcon-ptn5150.o
>>> ../drivers/extcon/extcon-ptn5150.c: In function ‘ptn5150_irq_work’:
>>> ../drivers/extcon/extcon-ptn5150.c:130:5: error: implicit declaration of function ‘gpiod_set_value’ [-Werror=implicit-function-declaration]
>>>      gpiod_set_value(info->vbus_gpiod, 0);
>>>      ^
>>> ../drivers/extcon/extcon-ptn5150.c: In function ‘ptn5150_i2c_probe’:
>>> ../drivers/extcon/extcon-ptn5150.c:242:2: error: implicit declaration of function ‘devm_gpiod_get’ [-Werror=implicit-function-declaration]
>>>   info->int_gpiod = devm_gpiod_get(&i2c->dev, "int", GPIOD_IN);
>>>   ^
>>> ../drivers/extcon/extcon-ptn5150.c:242:53: error: ‘GPIOD_IN’ undeclared (first use in this function)
>>>   info->int_gpiod = devm_gpiod_get(&i2c->dev, "int", GPIOD_IN);
>>>                                                      ^
>>> ../drivers/extcon/extcon-ptn5150.c:242:53: note: each undeclared identifier is reported only once for each function it appears in
>>> ../drivers/extcon/extcon-ptn5150.c:252:2: error: implicit declaration of function ‘gpiod_direction_output’ [-Werror=implicit-function-declaration]
>>>   ret = gpiod_direction_output(info->vbus_gpiod, 0);
>>>   ^
>>> ../drivers/extcon/extcon-ptn5150.c:271:3: error: implicit declaration of function ‘gpiod_to_irq’ [-Werror=implicit-function-declaration]
>>>    info->irq = gpiod_to_irq(info->int_gpiod);
>> -----
>>
>> Signed-off-by: Vijai Kumar K <vijaikumar.kanagarajan@...il.com>
>> ---
>>  drivers/extcon/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
>> index b9cc027..330dd8b 100644
>> --- a/drivers/extcon/Kconfig
>> +++ b/drivers/extcon/Kconfig
>> @@ -116,7 +116,7 @@ config EXTCON_PALMAS
>>  
>>  config EXTCON_PTN5150
>>  	tristate "NXP PTN5150 CC LOGIC USB EXTCON support"
>> -	depends on I2C
>> +	depends on I2C && GPIOLIB
>>  	select REGMAP_I2C
>>  	help
>>  	  Say Y here to enable support for USB peripheral and USB host
>> -- 
>> 2.7.4
>>


-- 
~Randy