linux-kernel - Re: [PATCH 2/2] iwlwifi: Use struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9a66aa07870c729ad0e65ac26a2404fac879f290.camel@perches.com>
Date:   Mon, 28 Jan 2019 13:57:45 -0800
From:   Joe Perches <joe@...ches.com>
To:     YueHaibing <yuehaibing@...wei.com>, johannes.berg@...el.com,
        emmanuel.grumbach@...el.com, luciano.coelho@...el.com,
        linuxwifi@...el.com, kvalo@...eaurora.org
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        linux-wireless@...r.kernel.org
Subject: Re: [PATCH 2/2] iwlwifi: Use struct_size() in kzalloc

On Mon, 2019-01-28 at 14:44 +0800, YueHaibing wrote:
> Use struct_size() in kzalloc instead of the 'regd_to_copy'

There is also the use above that in the same function
that could also be converted.

	/* build a regdomain rule for every valid channel */
	size_of_regd =
		sizeof(struct ieee80211_regdomain) +
		num_of_ch * sizeof(struct ieee80211_reg_rule);

	regd = kzalloc(size_of_regd, GFP_KERNEL);
	if (!regd)
		return ERR_PTR(-ENOMEM);

> diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c b/drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c
[]
> @@ -1093,7 +1093,7 @@ iwl_parse_nvm_mcc_info(struct device *dev, const struct iwl_cfg *cfg,
>  	const u8 *nvm_chan = cfg->nvm_type == IWL_NVM_EXT ?
>  			     iwl_ext_nvm_channels : iwl_nvm_channels;
>  	struct ieee80211_regdomain *regd, *copy_rd;
> -	int size_of_regd, regd_to_copy;
> +	int size_of_regd;
>  	struct ieee80211_reg_rule *rule;
>  	struct regdb_ptrs *regdb_ptrs;
>  	enum nl80211_band band;
> @@ -1193,10 +1193,8 @@ iwl_parse_nvm_mcc_info(struct device *dev, const struct iwl_cfg *cfg,
>  	 * Narrow down regdom for unused regulatory rules to prevent hole
>  	 * between reg rules to wmm rules.
>  	 */
> -	regd_to_copy = sizeof(struct ieee80211_regdomain) +
> -		valid_rules * sizeof(struct ieee80211_reg_rule);
> -
> -	copy_rd = kmemdup(regd, regd_to_copy, GFP_KERNEL);
> +	copy_rd = kmemdup(regd, struct_size(regd, reg_rules, valid_rules),
> +			  GFP_KERNEL);
>  	if (!copy_rd)
>  		copy_rd = ERR_PTR(-ENOMEM);
>