linux-kernel - Re: [PATCH v8 01/26] arm64: Fix HCR.TGE status for NMI contexts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <86munlw3a2.wl-marc.zyngier@arm.com>
Date:   Mon, 28 Jan 2019 09:16:21 +0000
From:   Marc Zyngier <marc.zyngier@....com>
To:     Julien Thierry <julien.thierry@....com>
Cc:     <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <daniel.thompson@...aro.org>,
        <joel@...lfernandes.org>, <christoffer.dall@....com>,
        <james.morse@....com>, <catalin.marinas@....com>,
        <will.deacon@....com>, <mark.rutland@....com>,
        Arnd Bergmann <arnd@...db.de>, <linux-arch@...r.kernel.org>,
        <stable@...r.kernel.org>
Subject: Re: [PATCH v8 01/26] arm64: Fix HCR.TGE status for NMI contexts

On Tue, 08 Jan 2019 14:07:19 +0000,
Julien Thierry <julien.thierry@....com> wrote:
> 
> When using VHE, the host needs to clear HCR_EL2.TGE bit in order
> to interract with guest TLBs, switching from EL2&0 translation regime
> to EL1&0.
> 
> However, some non-maskable asynchronous event could happen while TGE is
> cleared like SDEI. Because of this address translation operations
> relying on EL2&0 translation regime could fail (tlb invalidation,
> userspace access, ...).
> 
> Fix this by properly setting HCR_EL2.TGE when entering NMI context and
> clear it if necessary when returning to the interrupted context.
> 
> Signed-off-by: Julien Thierry <julien.thierry@....com>
> Suggested-by: Marc Zyngier <marc.zyngier@....com>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Catalin Marinas <catalin.marinas@....com>
> Cc: Will Deacon <will.deacon@....com>
> Cc: Marc Zyngier <marc.zyngier@....com>
> Cc: James Morse <james.morse@....com>
> Cc: linux-arch@...r.kernel.org
> Cc: stable@...r.kernel.org

Reviewed-by: Marc Zyngier <marc.zyngier@....com>

Thanks,

	M.

-- 
Jazz is not dead, it just smell funny.