linux-kernel - Re: [PATCH] netfilter: ipt_CLUSTERIP: fix warning unused variable cn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190128095143.5yxst4dn7pvodqwn@salvia>
Date:   Mon, 28 Jan 2019 10:51:43 +0100
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     Anders Roxell <anders.roxell@...aro.org>
Cc:     kadlec@...ckhole.kfki.hu, fw@...len.de, davem@...emloft.net,
        kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org,
        netfilter-devel@...r.kernel.org, coreteam@...filter.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] netfilter: ipt_CLUSTERIP: fix warning unused variable cn

On Wed, Jan 23, 2019 at 12:48:11PM +0100, Anders Roxell wrote:
> When CONFIG_PROC_FS isn't set the variable cn isn't used.
> 
> net/ipv4/netfilter/ipt_CLUSTERIP.c: In function ‘clusterip_net_exit’:
> net/ipv4/netfilter/ipt_CLUSTERIP.c:849:24: warning: unused variable ‘cn’ [-Wunused-variable]
>   struct clusterip_net *cn = clusterip_pernet(net);
>                         ^~
> 
> Rework so the variable 'cn' is declared inside "#ifdef CONFIG_PROC_FS".

Applied, thanks.