linux-kernel - Re: drivers/media/platform/imx-pxp.c:683: possible cut''n'paste error ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 28 Jan 2019 12:37:26 +0100
From:   Philipp Zabel <p.zabel@...gutronix.de>
To:     David Binderman <dcb314@...mail.com>,
        "mchehab@...nel.org" <mchehab@...nel.org>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: drivers/media/platform/imx-pxp.c:683: possible cut''n'paste
 error ?

On Sun, 2019-01-27 at 08:17 +0000, David Binderman wrote:
> Hello there,
> 
> drivers/media/platform/imx-pxp.c:683:24: warning: duplicated ‘if’ condition [-Wd
> uplicated-cond]
> 
> Source code is
> 
>                } else if (ycbcr_enc == V4L2_YCBCR_ENC_709) {
>                         if (quantization == V4L2_QUANTIZATION_FULL_RANGE)
>                                 csc2_coef = csc2_coef_rec709_full;
>                         else
>                                 csc2_coef = csc2_coef_rec709_lim;
>                 } else if (ycbcr_enc == V4L2_YCBCR_ENC_709) {
>                         if (quantization == V4L2_QUANTIZATION_FULL_RANGE)
>                                 csc2_coef = csc2_coef_bt2020_full;
>                         else
>                                 csc2_coef = csc2_coef_bt2020_lim;
>                 } else {
> 
> The condition on the second if looks wrong. Suggest code rework.

Thank you, I have sent a patch.

regards
Philipp