linux-kernel - Re: [PATCH v4 2/9] cpufreq: Auto-register the driver as a thermal cooling device if asked

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <12294707.IXbBkGfcfl@aspire.rjw.lan>
Date:   Mon, 28 Jan 2019 13:03:20 +0100
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:     Amit Kucheria <amit.kucheria@...aro.org>,
        linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        viresh.kumar@...aro.org, edubezval@...il.com, swboyd@...omium.org,
        dianders@...omium.org, mka@...omium.org,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>,
        Tao Wang <kevin.wangtao@...ilicon.com>,
        Sudeep Holla <sudeep.holla@....com>, linux-pm@...r.kernel.org
Subject: Re: [PATCH v4 2/9] cpufreq: Auto-register the driver as a thermal cooling device if asked

On Monday, January 28, 2019 9:32:44 AM CET Daniel Lezcano wrote:
> On 28/01/2019 07:41, Amit Kucheria wrote:
> > All cpufreq drivers do similar things to register as a cooling device.
> > Provide a cpufreq driver flag so drivers can just ask the cpufreq core
> > to register the cooling device on their behalf. This allows us to get
> > rid of duplicated code in the drivers.
> > 
> > In order to allow this, we add a struct thermal_cooling_device pointer
> > to struct cpufreq_policy so that drivers don't need to store it in a
> > private data structure.
> > 
> > Suggested-by: Stephen Boyd <swboyd@...omium.org>
> > Suggested-by: Viresh Kumar <viresh.kumar@...aro.org>
> > Signed-off-by: Amit Kucheria <amit.kucheria@...aro.org>
> > Reviewed-by: Matthias Kaehlcke <mka@...omium.org>
> > Tested-by: Matthias Kaehlcke <mka@...omium.org>
> > ---
> 
> [ ... ]
> 
> > +/*
> > + * Set by drivers that want the core to automatically register the cpufreq
> > + * driver as a thermal cooling device.
> > + */
> > +#define CPUFREQ_AUTO_REGISTER_COOLING_DEV	BIT(7)
> > +
> 
> Isn't the CPUFREQ_IS_COOLING_DEV more appropriate? We define a property
> of the cpufreq driver and the resulting action is to auto-register, no?

Yes.

Cheers,
Rafael