linux-kernel - Re: [PATCH v2] Bluetooth: btrtl: Restore old logic to assume firmware is already loaded

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <01926B42-A666-4C3C-A5EB-53EE4AD92EE8@holtmann.org>
Date:   Mon, 28 Jan 2019 13:25:12 +0100
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Kai-Heng Feng <kai.heng.feng@...onical.com>
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        Daniel Drake <drake@...lessm.com>,
        linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org
Subject: Re: [PATCH v2] Bluetooth: btrtl: Restore old logic to assume firmware
 is already loaded

Hi Kai-Heng,

> Realtek bluetooth may not work after reboot:
> [   12.446130] Bluetooth: hci0: RTL: rtl: unknown IC info, lmp subver a99e, hci rev 826c, hci ver 0008
> 
> This is a regression introduced by commit 26503ad25de8 ("Bluetooth:
> btrtl: split the device initialization into smaller parts"). The new
> logic errors out early when no matching IC info can be found, in this
> case it means the firmware is already loaded.
> 
> So let's assume the firmware is already loaded when we can't find
> matching IC info, like the old logic did.
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=201921
> Fixes: 26503ad25de8 ("Bluetooth: btrtl: split the device initialization into smaller parts")
> Cc: stable@...r.kernel.org # 4.19+
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@...onical.com>
> ---
> drivers/bluetooth/btrtl.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel