linux-kernel - Re: [PATCH v4 1/5] usb: fsl: Set USB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 28 Jan 2019 10:33:53 -0500 (EST)
From:   Alan Stern <stern@...land.harvard.edu>
To:     Yinbo Zhu <yinbo.zhu@....com>
cc:     Xiaobo Xie <xiaobo.xie@....com>, Jerry Huang <jerry.huang@....com>,
        Ran Wang <ran.wang_1@....com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Ramneek Mehresh <ramneek.mehresh@...escale.com>,
        Nikhil Badola <nikhil.badola@...escale.com>,
        Suresh Gupta <suresh.gupta@...escale.com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 1/5] usb: fsl: Set USB_EN bit to select ULPI phy

On Fri, 25 Jan 2019, Yinbo Zhu wrote:

> From: Nikhil Badola <nikhil.badola@...escale.com>
> 
> Set USB_EN bit to select ULPI phy for USB controller version 2.5
> 
> Signed-off-by: Nikhil Badola <nikhil.badola@...escale.com>
> Signed-off-by: Yinbo Zhu <yinbo.zhu@....com>
> ---

Acked-by: Alan Stern <stern@...land.harvard.edu>

> Change in v4:
> 		Incorrect indentation of the continuation line
> 
>  drivers/usb/host/ehci-fsl.c |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c
> index e3d0c1c..38674b7 100644
> --- a/drivers/usb/host/ehci-fsl.c
> +++ b/drivers/usb/host/ehci-fsl.c
> @@ -122,6 +122,12 @@ static int fsl_ehci_drv_probe(struct platform_device *pdev)
>  		tmp |= 0x4;
>  		iowrite32be(tmp, hcd->regs + FSL_SOC_USB_CTRL);
>  	}
> +
> +	/* Set USB_EN bit to select ULPI phy for USB controller version 2.5 */
> +	if (pdata->controller_ver == FSL_USB_VER_2_5 &&
> +	    pdata->phy_mode == FSL_USB2_PHY_ULPI)
> +		iowrite32be(USB_CTRL_USB_EN, hcd->regs + FSL_SOC_USB_CTRL);
> +
>  	/*
>  	 * Enable UTMI phy and program PTS field in UTMI mode before asserting
>  	 * controller reset for USB Controller version 2.5
>