linux-kernel - Re: [PATCH -next] drm/xen-front: Drop pointless static qualifier in fb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4c371af3-8856-39a7-d06e-6b55749567e5@epam.com>
Date:   Mon, 28 Jan 2019 06:36:08 +0000
From:   Oleksandr Andrushchenko <Oleksandr_Andrushchenko@...m.com>
To:     YueHaibing <yuehaibing@...wei.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>
CC:     "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "xen-devel@...ts.xen.org" <xen-devel@...ts.xen.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH -next] drm/xen-front: Drop pointless static qualifier in
 fb_destroy()

On 1/26/19 2:05 PM, YueHaibing wrote:
> There is no need to have the 'struct drm_framebuffer *fb' variable
> static since new value always be assigned before use it.
>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
Good catch, thank you!
Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@...m.com>
> ---
>   drivers/gpu/drm/xen/xen_drm_front_kms.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xen/xen_drm_front_kms.c b/drivers/gpu/drm/xen/xen_drm_front_kms.c
> index 860da05..c2955d3 100644
> --- a/drivers/gpu/drm/xen/xen_drm_front_kms.c
> +++ b/drivers/gpu/drm/xen/xen_drm_front_kms.c
> @@ -54,7 +54,7 @@ static void fb_destroy(struct drm_framebuffer *fb)
>   	  const struct drm_mode_fb_cmd2 *mode_cmd)
>   {
>   	struct xen_drm_front_drm_info *drm_info = dev->dev_private;
> -	static struct drm_framebuffer *fb;
> +	struct drm_framebuffer *fb;
>   	struct drm_gem_object *gem_obj;
>   	int ret;
>   
>
>
>
>
>