linux-kernel - Re: [PATCH] x86/events: Mark expected switch fall-throughs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190129152500.GA25706@zn.tnic>
Date:   Tue, 29 Jan 2019 16:25:00 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        linux-kernel@...r.kernel.org, Kees Cook <keescook@...omium.org>,
        Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH] x86/events: Mark expected switch fall-throughs

On Fri, Jan 25, 2019 at 12:49:17PM -0600, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
> 
> This patch fixes the following warnings:
> 
> In file included from arch/x86/events/intel/core.c:22:
> arch/x86/events/intel/core.c: In function ‘intel_pmu_init’:
> arch/x86/events/intel/../perf_event.h:668:17: warning: this statement may fall through [-Wimplicit-fallthrough=]
>   x86_pmu.quirks = &__quirk;     \
>   ~~~~~~~~~~~~~~~^~~~~~~~~~
> arch/x86/events/intel/core.c:4170:3: note: in expansion of macro ‘x86_add_quirk’
>    x86_add_quirk(intel_clovertown_quirk);
>    ^~~~~~~~~~~~~
> arch/x86/events/intel/core.c:4171:2: note: here
>   case INTEL_FAM6_CORE2_MEROM_L:
>   ^~~~
> arch/x86/events/intel/lbr.c:929:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> 
> Warning level 3 was used: -Wimplicit-fallthrough=3
> 
> This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough.
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> ---
>  arch/x86/events/intel/core.c | 2 ++
>  arch/x86/events/intel/lbr.c  | 1 +
>  2 files changed, 3 insertions(+)

You do know how to use scripts/get_maintainer.pl, right?

Because I don't see PeterZ on CC.

Please use that script when preparing patches.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.