lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 29 Jan 2019 10:03:07 -0800 From: Andrew Morton <akpm@...ux-foundation.org> To: Uladzislau Rezki <urezki@...il.com> Cc: Michal Hocko <mhocko@...e.com>, Matthew Wilcox <willy@...radead.org>, linux-mm@...ck.org, LKML <linux-kernel@...r.kernel.org>, Thomas Garnier <thgarnie@...gle.com>, Oleksiy Avramchenko <oleksiy.avramchenko@...ymobile.com>, Steven Rostedt <rostedt@...dmis.org>, Joel Fernandes <joelaf@...gle.com>, Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...e.hu>, Tejun Heo <tj@...nel.org> Subject: Re: [PATCH v1 2/2] mm: add priority threshold to __purge_vmap_area_lazy() On Tue, 29 Jan 2019 17:17:54 +0100 Uladzislau Rezki <urezki@...il.com> wrote: > > > + resched_threshold = (int) lazy_max_pages() << 1; > > > > Is the typecast really needed? > > > > Perhaps resched_threshold shiould have unsigned long type and perhaps > > vmap_lazy_nr should be atomic_long_t? > > > I think so. Especially that atomit_t is 32 bit integer value on both 32 > and 64 bit systems. lazy_max_pages() deals with unsigned long that is 8 > bytes on 64 bit system, thus vmap_lazy_nr should be 8 bytes on 64 bit > as well. > > Should i send it as separate patch? What is your view? Sounds good. When convenient, please.
Powered by blists - more mailing lists