linux-kernel - Re: [PATCH net] net: set default network namespace in init_dummy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190129.113051.1765896152662794323.davem@davemloft.net>
Date:   Tue, 29 Jan 2019 11:30:51 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     jelsasser@...neta.com
Cc:     josh@...asser.ca, ecree@...arflare.com, ktkhai@...tuozzo.com,
        jiri@...lanox.com, petrm@...lanox.com, edumazet@...gle.com,
        amritha.nambiar@...el.com, alexander.h.duyck@...el.com,
        lirongqing@...du.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: set default network namespace in
 init_dummy_netdev()

From: Josh Elsasser <jelsasser@...neta.com>
Date: Sat, 26 Jan 2019 14:38:33 -0800

> Assign a default net namespace to netdevs created by init_dummy_netdev().
> Fixes a NULL pointer dereference caused by busy-polling a socket bound to
> an iwlwifi wireless device, which bumps the per-net BUSYPOLLRXPACKETS stat
> if napi_poll() received packets:
> 
>   BUG: unable to handle kernel NULL pointer dereference at 0000000000000190
>   IP: napi_busy_loop+0xd6/0x200
>   Call Trace:
>     sock_poll+0x5e/0x80
>     do_sys_poll+0x324/0x5a0
>     SyS_poll+0x6c/0xf0
>     do_syscall_64+0x6b/0x1f0
>     entry_SYSCALL_64_after_hwframe+0x3d/0xa2
> 
> Fixes: 7db6b048da3b ("net: Commonize busy polling code to focus on napi_id instead of socket")
> Signed-off-by: Josh Elsasser <jelsasser@...neta.com>

Applied and queued up for -stable.