linux-kernel - Re: [PATCH] drm/nouveau: fix missing break in switch statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c1026416-6cab-725d-b13d-bebc1c3a7583@embeddedor.com>
Date:   Tue, 29 Jan 2019 15:04:33 -0600
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Colin King <colin.king@...onical.com>,
        Ben Skeggs <bskeggs@...hat.com>,
        David Airlie <airlied@...ux.ie>,
        dri-devel@...ts.freedesktop.org, nouveau@...ts.freedesktop.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/nouveau: fix missing break in switch statement



On 1/29/19 2:49 PM, Gustavo A. R. Silva wrote:
> 
> 
> On 10/8/18 3:47 PM, Colin King wrote:
>> From: Colin Ian King <colin.king@...onical.com>
>>
>> The NOUVEAU_GETPARAM_PCI_DEVICE case is missing a break statement and falls
>> through to the following NOUVEAU_GETPARAM_BUS_TYPE case and may end up
>> re-assigning the getparam->value to an undesired value. Fix this by adding
>> in the missing break.
>>
>> Detected by CoverityScan, CID#1460507 ("Missing break in switch")
>>
>> Fixes: 359088d5b8ec ("drm/nouveau: remove trivial cases of nvxx_device() usage")
>> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> 
> Reviewed-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> 
> Friendly ping:
> 
> Who can take this?
> 

BTW, this should be tagged for stable:

Cc: stable@...r.kernel.org

Thanks
--
Gustavo


>> ---
>>  drivers/gpu/drm/nouveau/nouveau_abi16.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/nouveau/nouveau_abi16.c b/drivers/gpu/drm/nouveau/nouveau_abi16.c
>> index e67a471331b5..6ec745873bc5 100644
>> --- a/drivers/gpu/drm/nouveau/nouveau_abi16.c
>> +++ b/drivers/gpu/drm/nouveau/nouveau_abi16.c
>> @@ -214,6 +214,7 @@ nouveau_abi16_ioctl_getparam(ABI16_IOCTL_ARGS)
>>  			WARN_ON(1);
>>  			break;
>>  		}
>> +		break;
>>  	case NOUVEAU_GETPARAM_FB_SIZE:
>>  		getparam->value = drm->gem.vram_available;
>>  		break;
>>