linux-kernel - Re: [PATCH v2] dt-bindings: aspeed-lpc: Make parameter optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <A29B3BAA-8FA1-4FED-AB8D-C6DA2C2F785C@fb.com>
Date:   Tue, 29 Jan 2019 23:00:11 +0000
From:   Vijay Khemka <vijaykhemka@...com>
To:     Lee Jones <lee.jones@...aro.org>
CC:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Joel Stanley <joel@....id.au>,
        Andrew Jeffery <andrew@...id.au>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-aspeed@...ts.ozlabs.org" <linux-aspeed@...ts.ozlabs.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "openbmc @ lists . ozlabs . org" <openbmc@...ts.ozlabs.org>
Subject: Re: [PATCH v2] dt-bindings: aspeed-lpc: Make parameter optional

Thanks Lee,

On 1/29/19, 4:30 AM, "Lee Jones" <lee.jones@...aro.org> wrote:

    On Fri, 18 Jan 2019, Vijay Khemka wrote:
    
    > Memory-region and flash phandle is not a required parameter, it is
    > optional to describe in device tree and needed only use basis.
    > 
    > Signed-off-by: Vijay Khemka <vijaykhemka@...com>
    > ---
    >  Documentation/devicetree/bindings/mfd/aspeed-lpc.txt | 3 +++
    >  1 file changed, 3 insertions(+)
    > 
    > diff --git a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
    > index 34dd89087cff..d28c4e117611 100644
    > --- a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
    > +++ b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
    > @@ -135,6 +135,9 @@ Required properties:
    >  - clocks:	contains a phandle to the syscon node describing the clocks.
    >  		There should then be one cell representing the clock to use
    >  
    > +Optional properties:
    > +These below properties are optional to define.
    
    This line is superfluous.  Please remove it.
I will remove it. I am assuming only 1 line to remove.
    
    > +
    >  - memory-region: A phandle to a reserved_memory region to be used for the LPC
    >  		to AHB mapping
    >  
    
    -- 
    Lee Jones [李琼斯]
    Linaro Services Technical Lead
    Linaro.org │ Open source software for ARM SoCs
    Follow Linaro: Facebook | Twitter | Blog