linux-kernel - Re: linux-next: build warning after merge of the spi tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 29 Jan 2019 07:25:24 +0000
From:   Schrempf Frieder <frieder.schrempf@...tron.de>
To:     Yogesh Narayan Gaur <yogeshnarayan.gaur@....com>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Mark Brown <broonie@...nel.org>
CC:     Linux Next Mailing List <linux-next@...r.kernel.org>,
        "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
        Boris Brezillon <bbrezillon@...nel.org>
Subject: Re: linux-next: build warning after merge of the spi tree

On 29.01.19 07:57, Yogesh Narayan Gaur wrote:
> Hi,
> 
>> -----Original Message-----
>> From: Stephen Rothwell [mailto:sfr@...b.auug.org.au]
>> Sent: Tuesday, January 29, 2019 7:33 AM
>> To: Mark Brown <broonie@...nel.org>
>> Cc: Linux Next Mailing List <linux-next@...r.kernel.org>; Linux Kernel Mailing
>> List <linux-kernel@...r.kernel.org>; Yogesh Narayan Gaur
>> <yogeshnarayan.gaur@....com>; Frieder Schrempf
>> <frieder.schrempf@...tron.de>; Boris Brezillon <bbrezillon@...nel.org>;
>> Ashish Kumar <ashish.kumar@....com>
>> Subject: linux-next: build warning after merge of the spi tree
>>
>> Hi all,
>>
>> After merging the spi tree, today's linux-next build (KCONFIG_NAME) produced
>> this warning:
>>
>> WARNING: modpost: missing MODULE_LICENSE() in drivers/spi/spi-nxp-fspi.o
>> see include/linux/module.h for more information
>>
> Can someone help in pointing out that why above warning message is coming for mentioned commit.
> Below MODULE_LICENSE string is present in the above mentioned file, drivers/spi/spi-nxp-fspi.c.
>      MODULE_LICENSE("GPL v2");

No, it is not present. Look at your patches [1] or at spi-next [2]. 
MODULE_LICENSE is definitely missing.

In patchwork the missing line was appended to the commit message instead 
of the actual patch for some reason.

[1] https://patchwork.kernel.org/patch/10764347/
[2] 
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git/commit/?h=for-next&id=a5356aef6a907c2e2aed0caaa2b88b6021394471