[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <154887649939.169292.7755423118611897741@swboyd.mtv.corp.google.com>
Date: Wed, 30 Jan 2019 11:28:19 -0800
From: Stephen Boyd <sboyd@...nel.org>
To: Eddie James <eajames@...ux.ibm.com>, Joel Stanley <joel@....id.au>
Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
linux-aspeed@...ts.ozlabs.org, Andrew Jeffery <andrew@...id.au>,
Michael Turquette <mturquette@...libre.com>,
linux-clk@...r.kernel.org,
Linux ARM <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 2/2] clk: aspeed: Setup video engine clocking
Quoting Eddie James (2018-12-14 07:47:53)
>
>
> On 12/13/2018 07:02 PM, Joel Stanley wrote:
>
> >
> >> + { 0x0, 2 },
> >> + { 0x1, 2 },
> >> + { 0x2, 3 },
> >> + { 0x3, 4 },
> >> + { 0x4, 5 },
> >> + { 0x5, 6 },
> >> + { 0x6, 7 },
> >> + { 0x7, 8 },
> >> + { 0 }
> >> +};
> >> @@ -317,6 +338,7 @@ struct aspeed_reset {
> >> [ASPEED_RESET_PECI] = 10,
> >> [ASPEED_RESET_I2C] = 2,
> >> [ASPEED_RESET_AHB] = 1,
> >> + [ASPEED_RESET_VIDEO] = 6,
> > You've added the reset line to the ASPEED_CLK_GATE_ECLK clock so you
> > do not need to separately expose the reset controller. Instead
> > enabling the clock will deassert the rest line for you.
> >
> > This means you should drop the change from the header too, and it
> > affects the bindings document for the video engine.
>
> I want that reset available separately for use in the video engine
> actually. I could do without it, but it's somewhat useful.
>
Joel, are you happy with these patches? I'm tempted to drop these
changes from my queue because there hasn't been any news in over a
month.
Powered by blists - more mailing lists