[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20190130210704.GW31919@minitux>
Date: Wed, 30 Jan 2019 13:07:04 -0800
From: Bjorn Andersson <bjorn.andersson@...aro.org>
To: Ramon Fried <ramon.fried@...il.com>
Cc: linux-remoteproc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] remoteproc: qcom_q6v5: don't auto boot remote processor
On Thu 24 May 12:21 PDT 2018, Ramon Fried wrote:
> Sometimes that rmtfs userspace module is not brought
> up fast enough and the modem crashes.
> disabling automated boot in the driver and triggering
> the boot from user-space sovles the problem.
>
> Signed-off-by: Ramon Fried <ramon.fried@...il.com>
While I don't think we have fully settled on the mechanism yet, it's
clear that we don't want this to auto boot using the existing mechanism.
So I picked this patch, with Sibi's ack.
Thanks,
Bjorn
> ---
> drivers/remoteproc/qcom_q6v5_pil.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/remoteproc/qcom_q6v5_pil.c b/drivers/remoteproc/qcom_q6v5_pil.c
> index cbbafdcaaecb..719ee96445b3 100644
> --- a/drivers/remoteproc/qcom_q6v5_pil.c
> +++ b/drivers/remoteproc/qcom_q6v5_pil.c
> @@ -1133,6 +1133,8 @@ static int q6v5_probe(struct platform_device *pdev)
> return -ENOMEM;
> }
>
> + rproc->auto_boot = false;
> +
> qproc = (struct q6v5 *)rproc->priv;
> qproc->dev = &pdev->dev;
> qproc->rproc = rproc;
> --
> 2.17.0
>
Powered by blists - more mailing lists