[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190130061059.GA2387@tuxbook-pro>
Date: Tue, 29 Jan 2019 22:10:59 -0800
From: Bjorn Andersson <bjorn.andersson@...aro.org>
To: Brian Norris <briannorris@...omium.org>
Cc: Kalle Valo <kvalo@...eaurora.org>, ath10k@...ts.infradead.org,
linux-wireless@...r.kernel.org,
Govind Singh <govinds@...eaurora.org>,
Erik Stromdahl <erik.stromdahl@...il.com>,
Wen Gong <wgong@...eaurora.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH for-5.0] ath10k: correct bus type for WCN3990
On Tue 29 Jan 15:12 PST 2019, Brian Norris wrote:
> WCN3990 is SNOC, not PCI. This prevents probing WCN3990.
>
> Fixes: 367c899f622c ("ath10k: add bus type check in ath10k_init_hw_params")
> Signed-off-by: Brian Norris <briannorris@...omium.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>
> ---
> This was a regression in 4.20.
>
> drivers/net/wireless/ath/ath10k/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c
> index 399b501f3c3c..e8891f5fc83a 100644
> --- a/drivers/net/wireless/ath/ath10k/core.c
> +++ b/drivers/net/wireless/ath/ath10k/core.c
> @@ -548,7 +548,7 @@ static const struct ath10k_hw_params ath10k_hw_params_list[] = {
> {
> .id = WCN3990_HW_1_0_DEV_VERSION,
> .dev_id = 0,
> - .bus = ATH10K_BUS_PCI,
> + .bus = ATH10K_BUS_SNOC,
> .name = "wcn3990 hw1.0",
> .continuous_frag_desc = true,
> .tx_chain_mask = 0x7,
> --
> 2.20.1.495.gaa96b0ce6b-goog
>
Powered by blists - more mailing lists