[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ddf3515d-efba-6cf0-e224-90966be9cb18@huawei.com>
Date: Wed, 30 Jan 2019 08:52:40 +0100
From: Roberto Sassu <roberto.sassu@...wei.com>
To: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
CC: <zohar@...ux.ibm.com>, <david.safford@...com>,
<monty.wiseman@...com>, <matthewgarrett@...gle.com>,
<linux-integrity@...r.kernel.org>,
<linux-security-module@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <keyrings@...r.kernel.org>,
<silviu.vlasceanu@...wei.com>
Subject: Re: [PATCH v8 1/7] tpm: dynamically allocate the allocated_banks
array
On 1/29/2019 8:29 PM, Jarkko Sakkinen wrote:
> On Thu, Jan 24, 2019 at 04:49:04PM +0100, Roberto Sassu wrote:
>> + chip->allocated_banks = kcalloc(1, sizeof(*chip->allocated_banks),
>> + GFP_KERNEL);
>> + if (!chip->allocated_banks) {
>> + rc = -ENOMEM;
>> + goto out;
>> + }
>> +
>> + chip->allocated_banks[0] = TPM2_ALG_SHA1;
>> + chip->nr_allocated_banks = 1;
>
> Everything else looks nice in this patch except this.
>
> You always branch for TPM 1.2, and it will always have just SHA1. This
> is unnecessary.
Without this, users of the TPM driver have to call tpm_is_tpm2() first,
while instead they can look directly at chip->allocated_banks.
Roberto
> /Jarkko
>
--
HUAWEI TECHNOLOGIES Duesseldorf GmbH, HRB 56063
Managing Director: Bo PENG, Jian LI, Yanli SHI
Powered by blists - more mailing lists