[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8b80d10a-3433-4749-4d09-cf71ce799d63@linaro.org>
Date: Wed, 30 Jan 2019 10:08:32 +0100
From: Jorge Ramirez <jorge.ramirez-ortiz@...aro.org>
To: Vinod Koul <vkoul@...nel.org>
Cc: sboyd@...nel.org, bjorn.andersson@...aro.org,
andy.gross@...aro.org, david.brown@...aro.org,
jassisinghbrar@...il.com, mark.rutland@....com,
mturquette@...libre.com, robh+dt@...nel.org, will.deacon@....com,
arnd@...db.de, horms+renesas@...ge.net.au, heiko@...ech.de,
sibis@...eaurora.org, enric.balletbo@...labora.com,
jagan@...rulasolutions.com, olof@...om.net,
niklas.cassel@...aro.org, georgi.djakov@...aro.org,
amit.kucheria@...aro.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-clk@...r.kernel.org, linux-arm-msm@...r.kernel.org,
khasim.mohammed@...aro.org
Subject: Re: [PATCH v2 10/14] arm64: dts: qcom: qcs404: Add OPP table
On 1/30/19 05:41, Vinod Koul wrote:
> On 28-01-19, 19:32, Jorge Ramirez-Ortiz wrote:
>> Add a CPU OPP table to qcs404
>>
>> Co-developed-by: Niklas Cassel <niklas.cassel@...aro.org>
>> Signed-off-by: Niklas Cassel <niklas.cassel@...aro.org>
>> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@...aro.org>
>> ---
>> arch/arm64/boot/dts/qcom/qcs404.dtsi | 15 +++++++++++++++
>> 1 file changed, 15 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi
>> index 9b5c165..4594fea7 100644
>> --- a/arch/arm64/boot/dts/qcom/qcs404.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi
>> @@ -62,6 +62,21 @@
>> };
>> };
>>
>> + cpu_opp_table: cpu_opp_table {
>
> This should be:
> cpu_opp_table: cpu-opp-table
yes. um I thought I fixed this ..sorry about it.
>
> IIRC node names are not supposed to have _ and tags not supposed to have
> -, please compile with W=12 to trigger these warnings :)
>
>> + compatible = "operating-points-v2";
>> + opp-shared;
>> +
>> + opp-1094400000 {
>> + opp-hz = /bits/ 64 <1094400000>;
>> + };
>> + opp-1248000000 {
>> + opp-hz = /bits/ 64 <1248000000>;
>> + };
also need to remove the frequency below. I might have sent the wrong
version of this file
>> + opp-1401600000 {
>> + opp-hz = /bits/ 64 <1401600000>;
>> + };
>> + };
>> +
>> firmware {
>> scm: scm {
>> compatible = "qcom,scm-qcs404", "qcom,scm";
>> --
>> 2.7.4
>
Powered by blists - more mailing lists