[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190130095938.GP3691@localhost>
Date: Wed, 30 Jan 2019 10:59:38 +0100
From: Johan Hovold <johan@...nel.org>
To: Myungho Jung <mhjungk@...il.com>
Cc: Marcel Holtmann <marcel@...tmann.org>,
Johan Hedberg <johan.hedberg@...il.com>,
linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Bluetooth: Add NULL check for tiocmget() and tiocmset()
On Sun, Jan 27, 2019 at 10:59:13PM -0800, Myungho Jung wrote:
> tiocmget() and tiocmset() operations are optional and some tty drivers
> like pty miss the operations. We need NULL check before referencing
> them.
Good catch. I suggest splitting these fixes in two separate patches
(after addressing Marcel's comments).
Don't forget to CC stable and add a Fixes-tag for each, as we we want to
have this backported to stable.
> Reported-by: syzbot+a950165cbb86bdd023a4@...kaller.appspotmail.com
Actually, these two bugs were never reported by sysbot AFAIKT so no need
to give credit to anyone else here.
> Signed-off-by: Myungho Jung <mhjungk@...il.com>
> ---
> drivers/bluetooth/hci_ath.c | 13 ++++++++-----
> drivers/bluetooth/hci_ldisc.c | 5 +++++
> 2 files changed, 13 insertions(+), 5 deletions(-)
Johan
Powered by blists - more mailing lists