linux-kernel - Re: [PATCH V3] livepatch: non static warnings fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190130101008.bki7aozn6qo4vrmc@pathway.suse.cz>
Date:   Wed, 30 Jan 2019 11:10:08 +0100
From:   Petr Mladek <pmladek@...e.com>
To:     Miroslav Benes <mbenes@...e.cz>
Cc:     Nicholas Mc Guire <hofrat@...dl.org>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Jessica Yu <jeyu@...nel.org>, Jiri Kosina <jikos@...nel.org>,
        live-patching@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V3] livepatch: non static warnings fix

On Wed 2019-01-23 15:30:57, Miroslav Benes wrote:
> Hi,
> 
> On Wed, 23 Jan 2019, Nicholas Mc Guire wrote:
> 
> > Sparse reported warnings about non-static symbols. For the variables
> > a simple static attribute is fine - for the functions referenced by
> > livepatch via klp_func the symbol-names must be unmodified in the
> > symbol table and the patchable code has to be emitted. The resolution
> > is to attach __used attribute to the shared statically declared functions.
> > 
> > Signed-off-by: Nicholas Mc Guire <hofrat@...dl.org>
> > Suggested-by: Joe Lawrence <joe.lawrence@...hat.com>
> > Link: https://lkml.org/lkml/2018/12/13/827
> 
> could you reorder the tags and change Link: tag to 
> https://lkml.kernel.org/r/<message_id> as asked for when we reviewed v2?

Just for record. My understanding is that the Link: tag usually points
to the mail with the final patch that was pushed.

It means that it is usually added by the maintainer and not the patch
sender.

Best Regards,
Petr