linux-kernel - Re: [PATCH v2] venus: enc: fix enum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3062ef17-ad35-68ba-5cad-be9de037e637@linaro.org>
Date:   Wed, 30 Jan 2019 12:35:54 +0200
From:   Stanimir Varbanov <stanimir.varbanov@...aro.org>
To:     Nicolas Dufresne <nicolas@...fresne.ca>,
        Stanimir Varbanov <stanimir.varbanov@...aro.org>,
        linux-media@...r.kernel.org
Cc:     Hans Verkuil <hverkuil@...all.nl>, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] venus: enc: fix enum_frameintervals

Hi Nicolas,

On 1/30/19 5:28 AM, Nicolas Dufresne wrote:
> Le mardi 22 janvier 2019 à 12:53 +0200, Stanimir Varbanov a écrit :
>> This ixes an issue when setting the encoder framerate because of
> 
> ixes -> fixes
> 
>> missing precision. Now the frameinterval type is changed to
>> TYPE_CONTINUOUS and step = 1. Also the math is changed when
>> framerate property is called - the firmware side expects that
>> the framerate one is 1 << 16 units.
> 
> Note sure, maybe you didn't mean to add 'one' here ? Why not just say
> that that firmware expect values in Q16 ?

yes, thanks for the suggestion.

> 
>>
>> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@...aro.org>
> 
> Looking toward testing it, but I had the bad luck of using an USB
> storage rootfs, and apparently USB no longer works on 5.0rc+, if you
> have a baseline tree to suggest, I'll take it. Thanks for this patch.

try qcomlt-4.14 release branch at [1].

-- 
regards,
Stan

[1]
https://git.linaro.org/landing-teams/working/qualcomm/kernel.git/log/?h=release/qcomlt-4.14