linux-kernel - Re: [PATCH v2] powerpc/traps: fix the message printed when stack overflows

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87o97ypbph.fsf@concordia.ellerman.id.au>
Date:   Wed, 30 Jan 2019 23:32:58 +1100
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Christophe Leroy <christophe.leroy@....fr>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>
Cc:     linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH v2] powerpc/traps: fix the message printed when stack overflows

Christophe Leroy <christophe.leroy@....fr> writes:

> Today's message is useless:
>
> [   42.253267] Kernel stack overflow in process (ptrval), r1=c65500b0
>
> This patch fixes it:
>
> [   66.905235] Kernel stack overflow in process sh[356], r1=c65560b0
>
> Fixes: ad67b74d2469 ("printk: hash addresses printed with %p")
> Cc: <stable@...r.kernel.org>
> Signed-off-by: Christophe Leroy <christophe.leroy@....fr>
> ---
>  v2: make checkpatch happy :)
>
>  arch/powerpc/kernel/traps.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/kernel/traps.c b/arch/powerpc/kernel/traps.c
> index 5e917a84f949..a3dc6872d5aa 100644
> --- a/arch/powerpc/kernel/traps.c
> +++ b/arch/powerpc/kernel/traps.c
> @@ -1535,8 +1535,8 @@ void alignment_exception(struct pt_regs *regs)
>  
>  void StackOverflow(struct pt_regs *regs)
>  {
> -	printk(KERN_CRIT "Kernel stack overflow in process %p, r1=%lx\n",
> -	       current, regs->gpr[1]);
> +	pr_crit("Kernel stack overflow in process %s[%d], r1=%lx\n",
> +		current->comm, current->pid, regs->gpr[1]);

I think you're meant to use task_pid_nr(current) these days.

I fixed it up when applying.

cheers