linux-kernel - Re: [PATCH v2] firmware: imx: Add support to start/stop a CPU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fc0ef2f1709cb678f29cd37d618e28a7ed606791.camel@nxp.com>
Date:   Wed, 30 Jan 2019 13:12:25 +0000
From:   Daniel Baluta <daniel.baluta@....com>
To:     "dongas86@...il.com" <dongas86@...il.com>
CC:     dl-linux-imx <linux-imx@....com>,
        Aisheng Dong <aisheng.dong@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "daniel.baluta@...il.com" <daniel.baluta@...il.com>,
        "festevam@...il.com" <festevam@...il.com>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "S.j. Wang" <shengjiu.wang@....com>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>
Subject: Re: [PATCH v2] firmware: imx: Add support to start/stop a CPU

Thanks Aisheng for the comments!

<snip>

+int imx_sc_pm_cpu_start(struct imx_sc_ipc *ipc, u32 resource,
> > +                       bool enable, u64 address)
> > +{
> > +       struct imx_sc_msg_req_cpu_start msg;
> > +       struct imx_sc_rpc_msg *hdr = &msg.hdr;
> > +
> > +       hdr->ver = IMX_SC_RPC_VERSION;
> > +       hdr->svc = (uint8_t)IMX_SC_RPC_SVC_PM;
> > +       hdr->func = (uint8_t)IMX_SC_PM_FUNC_CPU_START;
> 
> pls drop the unneccesary unit8_t

Ok, I can do that. I had borrowed it from the already existing
functions imx_sc_misc_get_control / imx_sc_misc_set_control

> 
> > +       hdr->size = 4;
> > +
> > +       msg.address_hi = address >> 32;
> > +       msg.address_lo = address;
> > +       msg.resource = resource;
> > +       msg.enable = enable;
> > +
> > +       return imx_scu_call_rpc(ipc, &msg, false);
> 
> s/false/true

Nice catch!

Inded, the old API had a different semantic for this parameter.
> 
> > +}
> > +EXPORT_SYMBOL(imx_sc_pm_cpu_start);
> > diff --git a/include/linux/firmware/imx/svc/misc.h
> > b/include/linux/firmware/imx/svc/misc.h
> > index e21c49aba92f..c03bf2a23add 100644
> > --- a/include/linux/firmware/imx/svc/misc.h
> > +++ b/include/linux/firmware/imx/svc/misc.h
> > @@ -52,4 +52,7 @@ int imx_sc_misc_set_control(struct imx_sc_ipc
> > *ipc, u32 resource,
> >  int imx_sc_misc_get_control(struct imx_sc_ipc *ipc, u32 resource,
> >                             u8 ctrl, u32 *val);
> > 
> > +int imx_sc_pm_cpu_start(struct imx_sc_ipc *ipc, u32 resource,
> > +                       bool enable, u64 address);
> 
> Nitpick: phy_addr

Ok, will fix.