linux-kernel - Re: [PATCH] refcount_t: add ACQUIRE ordering on success for dec(sub)_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190130142147.GD2296@hirez.programming.kicks-ass.net>
Date:   Wed, 30 Jan 2019 15:21:47 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Andrea Parri <andrea.parri@...rulasolutions.com>
Cc:     Elena Reshetova <elena.reshetova@...el.com>,
        linux-kernel@...r.kernel.org, dvyukov@...gle.com,
        stern@...land.harvard.edu, keescook@...omium.org
Subject: Re: [PATCH] refcount_t: add ACQUIRE ordering on success for
 dec(sub)_and_test variants

On Wed, Jan 30, 2019 at 01:31:31PM +0100, Andrea Parri wrote:
> On Wed, Jan 30, 2019 at 01:18:51PM +0200, Elena Reshetova wrote:
> > This adds an smp_acquire__after_ctrl_dep() barrier on successful
> > decrease of refcounter value from 1 to 0 for refcount_dec(sub)_and_test
> > variants and therefore gives stronger memory ordering guarantees than
> > prior versions of these functions.
> > 
> > Co-developed-by: Peter Zijlstra (Intel) <peterz@...radead.org>
> > Signed-off-by: Elena Reshetova <elena.reshetova@...el.com>
> 
> Reviewed-by: Andrea Parri <andrea.parri@...rulasolutions.com>

Thanks, got it queued now.